Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for config_search_paths #6885

Merged

Conversation

kirkkwang
Copy link
Contributor

Summary

This commit will allow gems to override the SimpleSchemaLoader#config_search_paths easily.

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

In gems that introduce a metadata yaml file, it would be nice to have a way to keep the yaml in the gem but add the path of the yaml to be loaded by the SimpleSchemaLoader.

Changes proposed in this pull request:

  • Add a configuration for the SimpleSchemaLoader to add different search paths.

@samvera/hyrax-code-reviewers

This commit will allow gems to override the
SimpleSchemaLoader#config_search_paths easily.
Copy link

Test Results

    17 files  ±0      17 suites  ±0   2h 18m 49s ⏱️ + 4m 14s
 6 706 tests +2   6 409 ✅ +3  297 💤 ±0  0 ❌  - 1 
13 180 runs  +2  12 785 ✅ +3  395 💤 ±0  0 ❌  - 1 

Results for commit 4d61d48. ± Comparison against base commit e4f8a06.

This pull request removes 273 and adds 275 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f359f5a4ed0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc613836540>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f359e2bc958>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc61319d5d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: d3ad5e5a-b631-4647-9ba0-62b18509d0a4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: af2a1a03-44c2-4752-ba90-1d24e7d1f138
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b5ed8b80-843a-4590-83eb-58f11dc5ae52
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: bc697243-cf0c-4b13-953f-947943070070
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 8fb7f762-e274-495f-b9c3-577bb717663b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 9781c893-9201-4e30-b352-01e08dee570d
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5a854a9890>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f75ce6d8210>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5a854be880>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f75cda0a010>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: dac58570-52a6-4ac4-a5f1-822ba21218fe
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3ae31942-1134-4390-ae6f-61f0ed16f1b8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d58d8ac9-4edf-4e56-b963-15fc5ed66759
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 62adbb9c-0ab0-4355-847d-e7f15273430d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e9f40282-d7db-4d07-8023-2044fa90dcd6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: d8a02080-41c5-4cbc-a16f-21f20c2d0fb1
…

@dlpierce dlpierce merged commit 9d8d5f8 into main Aug 12, 2024
22 checks passed
@dlpierce dlpierce deleted the configuration-for-simple-schema-loader-config-search-paths branch August 12, 2024 14:59
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants