Update facet pagination to fix #5549 #5583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5549
Fixes the logic for displaying
Previous
andNext
buttons inhyrax/app/views/hyrax/my/_facet_pagination.html.erb
. This ensures two randomspan
tags are no longer displayed. Refer to the following screenshots for the UI changes included in this PR:Before the fix:
After the fix:
Changes proposed in this pull request:
hyrax/app/views/hyrax/my/_facet_pagination.html.erb
, only display a disabledPrevious
button if the current page is the first pagehyrax/app/views/hyrax/my/_facet_pagination.html.erb
, only display a disabledNext
button if the current page is the last pageGuidance for testing, such as acceptance criteria or new user interface behaviors:
Resource Type
filterPrevious
button is disabled if current page is the first pageNext
button is disabled if current page is the last pagePrevious
andNext
button work properly when there are multiple pages of resource types to filter works@samvera/hyrax-code-reviewers