Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update facet pagination to fix #5549 #5583

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

abelemlih
Copy link
Contributor

Fixes #5549

Fixes the logic for displaying Previous and Next buttons in hyrax/app/views/hyrax/my/_facet_pagination.html.erb. This ensures two random span tags are no longer displayed. Refer to the following screenshots for the UI changes included in this PR:

Before the fix:

Screen Shot 2022-03-25 at 10 55 07 PM

After the fix:

Screen Shot 2022-03-25 at 10 48 10 PM

Changes proposed in this pull request:

  • In hyrax/app/views/hyrax/my/_facet_pagination.html.erb, only display a disabled Previous button if the current page is the first page
  • In hyrax/app/views/hyrax/my/_facet_pagination.html.erb, only display a disabled Next button if the current page is the last page

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  1. Go to Dashboard
  2. Go to Works
  3. Click on Resource Type filter
  4. Click more >>
  • Ensure Previous button is disabled if current page is the first page
  • Ensure Next button is disabled if current page is the last page
  • Ensure Previous and Next button work properly when there are multiple pages of resource types to filter works

@samvera/hyrax-code-reviewers

@abelemlih abelemlih force-pushed the abel-5549-fix_facet_pagination_ui branch from e1346a5 to 1d6c95d Compare March 26, 2022 03:00
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for making the PR, looks good to me!

@abelemlih abelemlih merged commit 3be60c7 into main Mar 29, 2022
@abelemlih abelemlih deleted the abel-5549-fix_facet_pagination_ui branch March 29, 2022 17:05
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unnecessary plain text spans from _facet_pagination
3 participants