Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky file ordering in spec for ValkyrieIngestJob #5570

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

dlpierce
Copy link
Member

The order that files are returned can vary causing the test to fail sometimes. This makes the spec not care about the ordering.

@samvera/hyrax-code-reviewers

cjcolvar
cjcolvar previously approved these changes Mar 23, 2022
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this! The past couple days I've had to restart the tests many times to get them to pass. This is a huge help!

I had one small suggestion that isn't a blocker.

spec/jobs/valkyrie_ingest_job_spec.rb Outdated Show resolved Hide resolved
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@dlpierce
Copy link
Member Author

Thanks, that's much cleaner.

@cjcolvar cjcolvar merged commit 4c19640 into main Mar 24, 2022
@cjcolvar cjcolvar deleted the flaky_valk_ingest_job_spec branch March 24, 2022 02:04
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants