Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove title from index and update translations #2450

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

kirkkwang
Copy link
Collaborator

This commit will remove the title property from the index show page because it already shows up in a different partial so it's redundant. Also, there were a few missing translations so those have been updated. It seemed that the translations were in two different spots so I consolidated them so it's easier to manage. I've updated the other languages as well using the i18n Google translate task.

Before:
image

After:
image

This commit will remove the title property from the index show page
because it already shows up in a different partial so it's redundant.
Also, there were a few missing translations so those have been updated.
It seemed that the translations were in two different spots so I
consolidated them so it's easier to manage.  I've updated the other
languages as well using the i18n Google translate task.
@kirkkwang kirkkwang added the patch-ver for release notes label Feb 10, 2025
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 43s ⏱️ -41s
2 059 tests ±0  2 003 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 086 runs  ±0  2 028 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 5405bf7. ± Comparison against base commit 0d3b9d2.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a1155f8b-2994-4851-870d-cb215134fd2d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 8ef988bc-c52c-42fd-aff3-c1ffb6c343ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7adee70c-f07e-4672-89dd-a6085a34a7ea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 41eb3f4a-490f-4b0c-99a6-f72799b03b73
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 0720bf53-18c1-4151-9b2b-b2b7c9413a8b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 48e950e9-b779-4485-a2f9-2bfc64c41277
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 36bf46f5-2379-4c3c-a60b-d6ab7cf3bcd1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c9e6f8c3-0221-4dfa-93bd-c37b0f4891fe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7d42de87-0ee9-4e47-b445-85f7a78023cc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 66a9b3ec-419f-4501-bcde-73fa78da58cf
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 350388f9-5ee4-4969-a132-3c6eccc37ea5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 762cbc8d-b006-4f63-9fca-8bd60b5aa1ea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 85da77c6-5d48-46be-97c1-1bdfd8ea33a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 6b54fa99-59f8-492e-b741-83e1b4c000ad
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 88b067c2-109d-465d-a92f-94ba578bc50e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ed1c67ff-630d-4a50-8cb1-e9aab7c5adce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 64c4375b-4bdd-4e39-8372-eea216816466
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 182e1f91-e580-4613-8b89-397a715951e4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7e6bac70-d531-49ca-852b-9ec5765d2ba3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 9551e8eb-313a-4c24-adf7-8352ac716e4b
…

@kirkkwang kirkkwang merged commit d9b2bac into main Feb 10, 2025
9 checks passed
@kirkkwang kirkkwang deleted the remove-title-from-index-and-update-translations branch February 10, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants