-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fixes based on issues found in Adventist #2449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in fix for BatchCreateJob.
Test Results 3 files ±0 3 suites ±0 17m 52s ⏱️ -7s Results for commit 6868880. ± Comparison against base commit 1e1e586. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
This commit addresses all views where the long titles were not wrapping. The titles had been stretching the containers and distorting many layouts.
fa8894d
to
6868880
Compare
kirkkwang
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
be318f0 Brings in fix for BatchCreateJob
The BatchCreateJob was overwriting attributes, causing a retry to fail due to missing attributes.
6868880 Handles long titles in views
Due to the way IiifPrint creates child works, there were some very long titles which were all one word. These long titles can distort views by stretching containers. Normally this wouldn't be a major issue, but early IiifPrint child works that weren't fully split correctly did not have the attribute to prevent them from appearing in public views.
These CSS and/or html changes wrap long titles to avoid distortions.
Home page
Default
Cultural
Institutional
Neutral
Catalog page
List view
Gallery view
Work show
Default
Cultural
Scholarly
Collection show - work list
List view
Gallery view
Dashboard works list