Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes based on issues found in Adventist #2449

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Feb 8, 2025

Summary

be318f0 Brings in fix for BatchCreateJob

The BatchCreateJob was overwriting attributes, causing a retry to fail due to missing attributes.

6868880 Handles long titles in views

Due to the way IiifPrint creates child works, there were some very long titles which were all one word. These long titles can distort views by stretching containers. Normally this wouldn't be a major issue, but early IiifPrint child works that weren't fully split correctly did not have the attribute to prevent them from appearing in public views.

These CSS and/or html changes wrap long titles to avoid distortions.

Home page

Default

Screenshot 2025-02-08 at 3 13 30 PM
Screenshot 2025-02-08 at 3 13 36 PM

Cultural

Screenshot 2025-02-08 at 3 41 56 PM

Institutional

Screenshot 2025-02-08 at 4 06 30 PM

Neutral

Screenshot 2025-02-08 at 4 15 52 PM

Catalog page

List view

Screenshot 2025-02-08 at 4 21 52 PM

Gallery view

Screenshot 2025-02-08 at 4 22 04 PM

Work show

Default

Screenshot 2025-02-08 at 2 17 46 PM

Cultural

Screenshot 2025-02-08 at 4 23 43 PM

Scholarly

Screenshot 2025-02-08 at 5 46 42 PM

Collection show - work list

List view

Screenshot 2025-02-08 at 5 50 51 PM

Gallery view

Screenshot 2025-02-08 at 5 51 05 PM

Dashboard works list

Screenshot 2025-02-08 at 3 28 56 PM

Brings in fix for BatchCreateJob.
@laritakr laritakr added the patch-ver for release notes label Feb 8, 2025
Copy link

github-actions bot commented Feb 8, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 52s ⏱️ -7s
2 059 tests ±0  2 003 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 086 runs  ±0  2 028 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 6868880. ± Comparison against base commit 1e1e586.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy d52f9ea1-8f8f-4bcc-a30a-fa0e4f4f1e78
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 515c2873-b40d-4352-8d06-a8e84ec08fa2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read c71f444d-ea3d-4007-a66c-60a1bc04a7c0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 23b88254-ed39-4858-822e-c6a6a01a0198
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 9c22a70a-d624-4e3a-b9c6-33b457b47b08
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 91a2e7c9-beb7-4574-96df-32af30da8e8e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3b7f5521-6d30-41f5-9d0a-b3d85ce45079
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e493c66f-af74-41c0-afd7-b02c45a57505
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 249e668b-10dd-46fb-8e3b-429b2aab1dba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1c5073a9-abd9-4100-b004-358c61bcf005
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e9963123-6e01-4734-a36d-30837c85f59e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a6eff41f-6c79-4c09-8b8b-92d7272654da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 3e59f1a8-8a63-4c19-8633-9628f3e0129a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 5342d2c6-407e-4d56-a0fc-c397e78afb11
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 42a8e70f-6337-4ae5-afc8-df7ebbd535c9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 0ef43ac3-5533-44d0-a3b3-3f817ac4c4af
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 29090ef2-d03f-4398-a2b7-c1e0eb00acb4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3aace1ff-fc30-43cc-81ad-69395364895b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 26fd4e3b-4504-46fe-bf14-817dc9577666
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 388cf07e-aea7-41df-86b1-79aec562bf7c
…

♻️ This comment has been updated with latest results.

This commit addresses all views where the long titles
were not wrapping. The titles had been stretching
the containers and distorting many layouts.
@laritakr laritakr force-pushed the more-adventist-fixes branch from fa8894d to 6868880 Compare February 8, 2025 22:53
@laritakr laritakr marked this pull request as ready for review February 8, 2025 23:14
Copy link
Collaborator

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@laritakr laritakr merged commit 0d3b9d2 into main Feb 9, 2025
8 checks passed
@laritakr laritakr deleted the more-adventist-fixes branch February 9, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants