Move js require higher in the install generator #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will alter the install generator to move the require for bulkrax/application above dataTables require. This was causing jquery errors in Hyku applications because of recent changes. Ref: - #836
|
Instead of tinkering the generator, we are opting to adjust Hyda's application.js to include bootstrap instead of having it in Bulkrax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to make Bulkrax's javascript work in Hydra, we needed to add bootstrap's JS to bulkrax, along with jquery since bootstrap depends on jquery.
In hyku apps, this caused unintended behavior with the dataTables in the dashboard.
The data tables needed to be required AFTER bulkrax in order to keep their functionality in hyku.
This commit will alter the install generator to insert the require for
bulkrax/applicationabove dataTables require.co-author: @summer-cook
Ref:
Screenshots
generated require
Note
This may need to be changed for existing hyku applications with Bulkrax.
adding bootstrap javascript was a potential breaking change for some applications: existing hyku applications will need to change the order of these requires.