Fix create and validate button #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alishaevn
approved these changes
Jun 28, 2023
|
Please link the issue to this PR @DeonFranklin |
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Prior to these changes:
In Bulkrax, the Create and Validate button is affected by a bug known in the community. Within SoftServe we agreed to hide this button to reduce the confusion it’s causing amongst Bulkrax users. We will create an issue as a reminder to discuss and/or fix the functionality of this button in the future.
With these changes:
After discussion, the solution we chose to implement was to add a conditional statement to the importer's new.html.erb file that hides the Create and Validate button until the bug is fixed.
Screenshots
ENV Variable set to true
ENV Variable set to false
ENV Variable set to violet
ENV Variable set to no value
Acceptance Criteria
The Create and Validate button on the importer form functions as expected.