Removes IndentationConsistency supported styles #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given these are the only two options for this attribute, do we want to continue to spend support time updating these options, or should we allow any options Rubocop allows? Put another way, is this a good way to address this issue, or should we remove the supported styles portion of this rule? |
remove, i think. |
|
+1 for remove |
|
👍 I'll update the PR |
Bixby will accept any option that Rubocop will accept.
rotated8
changed the title
bess
approved these changes
Jun 10, 2020
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unsupported
railsstyle, and addsindented_internal_methods, which replaces it.Note: the Rubocop docs do not mention when this change happened:
https://docs.rubocop.org/rubocop/0.85/cops_layout.html#layoutindentationconsistency