Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping node_modules directory when running cops #30

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

cgalarza
Copy link

We have started adopting bixby in some of our projects and I am seeing that some of js libraries are being linted by rubocop.

As part of the default rubocop v0.63.1 configuration the node_modules directory is excluded:
https://github.com/rubocop-hq/rubocop/blob/v0.63.1/config/default.yml#L61

Would it be possible to add node_modules to the list of excluded directories? Or is this something we should do locally?

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bess bess merged commit 6e7ebec into master Dec 10, 2019
@bess bess deleted the cgalarza-excluding-node-modules branch December 10, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants