Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make withCredentials work with videojs 7.x and 8.x #642

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Make withCredentials work with videojs 7.x and 8.x #642

merged 1 commit into from
Sep 18, 2024

Conversation

mbklein
Copy link
Member

@mbklein mbklein commented Sep 17, 2024

Instead of using the hlsOptions property to pass the credentials flag down to VideoJS, set withCredentials: true on each of the sources.

@mbklein mbklein requested a review from Dananji September 17, 2024 23:21
cjcolvar
cjcolvar approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your hard work on this!

@cjcolvar cjcolvar merged commit e83b0af into samvera-labs:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

@Dananji Dananji Awaiting requested review from Dananji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbklein @cjcolvar