Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native player #531

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Native player #531

merged 2 commits into from
Jun 21, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jun 20, 2024 •
edited
Loading

Related issue: #516

Removing custom start property in the demo site manifests, since the iOS native player cannot seem to handle the custom start for the demo data.
New issue to look at this: #530

cjcolvar
cjcolvar approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It would be good to get the start position fixed so it can be shown as an example on the demo page again.

@Dananji Dananji merged commit 02cb4c2 into main Jun 21, 2024
2 checks passed
@Dananji Dananji deleted the native-player branch June 21, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar