Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen crashing in Safari in iPad on iOS 17 #412

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix fullscreen crashing in Safari in iPad on iOS 17 #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/MediaPlayer/VideoJS/components/js/VideoJSProgress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class VideoJSProgress extends vjsComponent {
* @param {Number} curTime current time of the player
*/
handleTimeUpdate(curTime) {
const { player, times, options, state } = this;
const { player, times, options } = this;
const { targets, srcIndex } = options;
const { start, end } = times;

Expand Down Expand Up @@ -162,7 +162,6 @@ class VideoJSProgress extends vjsComponent {
mount() {
ReactDOM.render(
<ProgressBar
handleOnChange={this.handleOnChange}
player={this.player}
handleTimeUpdate={this.handleTimeUpdate}
initCurrentTime={this.options.currentTime}
Expand Down Expand Up @@ -466,7 +465,6 @@ function ProgressBar({ player, handleTimeUpdate, initCurrentTime, times, options
onPointerMove={(e) => handleMouseMove(e, false)}
id="slider-range"
ref={sliderRangeRef}
tabIndex={0}
></input>
{tRight.length > 0 ? (
createRange(tRight)
Expand Down
1 change: 1 addition & 0 deletions src/styles/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
.vjs-mobile-visible {
opacity: 1 !important;
display: inline;
z-index: 50;
}

/* Make VideoJS control bar buttons smaller */
Expand Down