Replace pointer handlers for transcript auto-scroll check with a checkbox #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
approved these changes
Feb 2, 2024
|
Only initially tested in Ramp demo site in Chrome on Mac and Safari/Chrome on iPad. In those scenarios, this is an elegant solution. I tried turning the auto-scroll on/off, scrubbing through media via progress bar and transcript, letting the transcript active cue progress below the visible display and turning auto-scroll back on. Auto-scroll is on by default and most users will just leave it that way and it will continue to work well. Users who have an issue in a scenario like a mobile device can turn it off if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a checkbox to turn on/off auto-scroll for transcript content:
With time-synced transcripts:
With non time-synced transcripts:
Related issue: #354