Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override Safari's native text track functionality #367

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Override Safari's native text track functionality #367

merged 1 commit into from
Jan 31, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jan 30, 2024 •
edited
Loading

Related issue: #325

masaball
masaball approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Dananji Dananji merged commit 10fc908 into main Jan 31, 2024
2 checks passed
@Dananji Dananji deleted the fix-captions-ios branch January 31, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @masaball