Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove id attributes from svg elements and condense g elements #341

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Remove id attributes from svg elements and condense g elements #341

merged 1 commit into from
Jan 17, 2024

Conversation

cjcolvar
Copy link
Member

Dananji
Dananji approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcolvar cjcolvar merged commit b1dbf10 into main Jan 17, 2024
2 checks passed
@cjcolvar cjcolvar deleted the repeated_svg_ids branch January 17, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dananji Dananji Dananji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element IDs are not unique for player SVG controls
2 participants
@cjcolvar @Dananji