Display placeholder canvas message for all empty manifests #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Dananji
commented
Nov 1, 2023
Dananji
commented
Dananji
force-pushed
the
empty-canvas-message
branch
from
a8c9bc4 to
8da9d39
Compare
cjcolvar
reviewed
Nov 3, 2023
src/components/MediaPlayer/VideoJS/components/js/VideoJSProgress.js
Outdated
Show resolved
Hide resolved
cjcolvar
reviewed
Nov 8, 2023
There was a problem hiding this comment.
I'm a little confused about what problem initTimeRef is solving and how it is solving it but if it is working than I don't necessarily need to fully understand it. It also seems like the timeupdate handling in VideoJSCurrentTime and VideoJSProgress could be extracted into a common method but that doesn't need to be done within the scope of this PR and could be done later if they end up really being the same.
src/components/MediaPlayer/VideoJS/components/js/VideoJSCurrentTime.js
Outdated
Show resolved
Hide resolved
src/components/MediaPlayer/VideoJS/components/js/VideoJSProgress.js
Outdated
Show resolved
Hide resolved
…tTime.js Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
…ss.js Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.