Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player css for zooming in demo site #248

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix player css for zooming in demo site #248

merged 1 commit into from
Sep 25, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Sep 22, 2023

The issue with icons in the control bar we were seeing when zooming-in was happening only in the demo site, because it sets the player width to 60%. The issue was not with VideoJS CSS. Example screenshots below where the player's width is not adjusted show the full control bar at 240% zoom level in the browser.

GitHub documentation site:
image

avalon-dev:
image

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Dananji Dananji merged commit c04c6b1 into main Sep 25, 2023
@Dananji Dananji deleted the fix-zoom-demo branch September 25, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants