-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add top level auto-advance toggle component. #218
Conversation
cjcolvar
commented
Aug 18, 2023
•
edited by Dananji
Loading
edited by Dananji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Have a couple suggestions in the test suite, but nothing else jumped out.
Co-authored-by: Mason Ballengee <masaball@iu.edu>
The last change I made wires the toggle up to the manifest state and the player will check that when a canvas ends playing before moving on to the next canvas. This is a fairly significant change in behavior for the player as it autoplayed by default before. We could add |
There is a |
… context even if toggle component isn't used
Looks good 💯 |
This looks great 💯 |