Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Styleguidist docs for MediaPlayer component #200

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jun 14, 2023

MediaPlayer component is not included in the Styleguidist docs.
This PR includes changes in the code with some re-structuring in src/components/MediaPlayer directory to facilitate this.

Screenshot from 2023-06-20 17-02-23

Merge after #199

@Dananji Dananji force-pushed the mediaplayer-docs branch from 3d56e31 to 050a380 Compare June 20, 2023 21:01
@Dananji Dananji marked this pull request as ready for review June 20, 2023 21:02
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a minor typo in a couple of the URIs, but once those are fixed I think it's good to merge.

public/prod/lunchroom_manners.json Outdated Show resolved Hide resolved
public/prod/lunchroom_manners.json Outdated Show resolved Hide resolved
Dananji and others added 2 commits June 22, 2023 10:48
Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com>
Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com>
@Dananji Dananji merged commit 0f82dad into main Jun 22, 2023
@Dananji Dananji deleted the mediaplayer-docs branch June 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants