Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor bugs in structure nav and file download #143

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Fix minor bugs in structure nav and file download #143

merged 2 commits into from
Jun 27, 2022

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jun 27, 2022

These minor bugs were identified while testing cookbook recipe manifests in the components.
This PR fixes the following bugs:

  • Structure navigation was not working properly where there are mediafragments without an end time (assumes the duration of the media file is the end time)
  • File download for alternative files in the manifest (under rendering property) were not working for cross-origin files

cjcolvar
cjcolvar approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/components/MediaPlayer/VideoJSPlayer.js Outdated Show resolved Hide resolved
@Dananji Dananji merged commit 99f4143 into main Jun 27, 2022
@Dananji Dananji deleted the minor-bugs branch June 27, 2022 19:54
@Dananji Dananji restored the minor-bugs branch April 11, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar