Merge pull request #427 from samvera-labs/null-metadata

Interpret null values in metadata as empty strings
samvera-labs · Feb 22, 2024 · ae27b3c · ae27b3c
2 parents 267a0ec + 374d4ef
commit ae27b3c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/services/iiif-parser.js b/src/services/iiif-parser.js
@@ -552,7 +552,7 @@ export function parseMetadata(metadata, resourceType) {
   if (metadata?.length > 0) {
     metadata.map(md => {
       // get value and replace /n characters with <br/> to display new lines in UI
-      let value = md.getValue().replace(/\n/g, "<br />");
+      let value = md.getValue()?.replace(/\n/g, "<br />");
       let sanitizedValue = sanitizeHtml(value, { ...HTML_SANITIZE_CONFIG });
       parsedMetadata.push({
         label: md.getLabel(),

diff --git a/src/services/iiif-parser.test.js b/src/services/iiif-parser.test.js
@@ -589,6 +589,12 @@ describe('iiif-parser', () => {
         label: "Notes", value: "<a></a>"
       });
     });
+
+    it('interprets null value as an empty string', () => {
+      const { manifestMetadata, _ } = iiifParser.getMetadata(lunchroomManifest, false);
+      expect(manifestMetadata.length).toBeGreaterThan(0);
+      expect(manifestMetadata[9]).toEqual({ label: "Notes", value: "" });
+    });
   });
 
   describe('parseAutoAdvance()', () => {

diff --git a/src/test_data/lunchroom-manners.js b/src/test_data/lunchroom-manners.js
@@ -44,6 +44,10 @@ export default {
     {
       label: { en: ["Table of Contents"] },
       value: { en: ["ToC\n--\nFirst Chapter\n--\nSecond Chapter", "This is a second table of contents field.\n\nMore chapters here?"] }
+    },
+    {
+      label: { en: ["Notes"] },
+      value: null
     }
   ],
   rendering: [