First draft of custom event handler support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelint
requested changes
Sep 4, 2024
tests/test_functional/fastapi_chat_completion_openai/server_openai.py
Outdated
Show resolved
Hide resolved
langchain_openai_api_bridge/core/utils/pydantic_async_iterator.py
Outdated
Show resolved
Hide resolved
etburke
commented
Sep 5, 2024
|
Okay! I've made some updates attempting to address your initial feedback. Let me know if you have any other thoughts. |
|
@samuelint any thoughts on this? |
samuelint
requested changes
Sep 19, 2024
langchain_openai_api_bridge/chat_completion/langchain_stream_adapter.py
Outdated
Show resolved
Hide resolved
langchain_openai_api_bridge/chat_completion/langchain_stream_adapter.py
Outdated
Show resolved
Hide resolved
tests/test_functional/fastapi_chat_completion_openai/server_openai.py
Outdated
Show resolved
Hide resolved
I've reviewed again, sorry for the delay. |
|
Alright, changes made. All tests passing. |
samuelint
approved these changes
Sep 21, 2024
tests/test_functional/fastapi_chat_completion_openai/server_openai.py
Outdated
Show resolved
Hide resolved
|
Thanks @samuelint ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #41
Apologies, I'm a Python novice. Please don't hesitate to reject this approach and/or provide feedback/guidance.