Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up PyO3 to 0.22.2 #287

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Bump up PyO3 to 0.22.2 #287

merged 3 commits into from
Aug 4, 2024

Conversation

FlickerSoul
Copy link
Contributor

@FlickerSoul FlickerSoul commented Jul 8, 2024

This PR bumps PyO3 to 0.22.2 to support Python 3.13. Note that because PyO3 is still working on free-threaded Python 3.13, the build only works on 3.13 with GIL.

Related to #276, #286, and #277

@EwoutH
Copy link

EwoutH commented Jul 10, 2024

Thanks a lot!

@samuelcolvin would you be able to review and merge this PR, and tag a new release?

@FriedrichFroebel
Copy link

Why does this PR delete the Cargo.lock file? It tends to be useful for different cases, for example to determine the package versions known to work and to know the versions used for building a release.

@FlickerSoul
Copy link
Contributor Author

Hi @FriedrichFroebel! The Cargo.lock is not deleted. The changes are just folded by GitHub. If you click the Load Diff, you can see the diff caused by updating the dependencies. :)

@FlickerSoul FlickerSoul changed the title Bump up PyO3 to 0.22.1 Bump up PyO3 to 0.22.2 Jul 25, 2024
@EwoutH
Copy link

EwoutH commented Jul 26, 2024

samuelcolvin would you be able to review and merge this PR, and tag a new release?

Sorry, to be a bit assertive @samuelcolvin, but could you give a timeline when you will be able to review and merge this PR? @FlickerSoul clearly put an effort in, and there are downstream dependencies waiting on this PR to be merged and a new release to be tagged.

It’s okay if it takes a while because whatever reason, but please communicate with us.

@EwoutH
Copy link

EwoutH commented Aug 4, 2024

Python 3.13 is now in it's release candidate phase and packages need to be uploaded to PyPI.

@samuelcolvin, could you give any sign of life?

@samuelcolvin samuelcolvin merged commit a81a7c6 into samuelcolvin:main Aug 4, 2024
43 checks passed
@samuelcolvin
Copy link
Owner

Merged, sorry for the delay, I'll try to make a release tomorrow.

@samuelcolvin
Copy link
Owner

Thanks so much for the contribution @FlickerSoul.

@EwoutH
Copy link

EwoutH commented Aug 4, 2024

Thanks for getting back!

Could you also include #277 in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants