Avoid possible race when selecting nibble2base implementation #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selecting which version of nibble2base() to use on first call is fine in a single thread, but may lead to a race in multi-threaded code. While this is likely harmless (the value stored to the function pointer will always be the same, and the update will probably be a single store), it is best to avoid the problem by making the selection at library initialisation, before any threads have started. As the optimised nibble2base_ssse3() already uses gcc function attributes, it seems reasonable to use __attribute__((constructor)) on the function that selects the version to use. If the constructor does not run, it will use the non-optimised version, which is a safe default.
|
Thanks for looking into this. Doing the dynamic update at load makes more sense than doing it at function call. I will use this in my code as well from now on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting which version of nibble2base() to use on first call is fine in a single thread, but may lead to a race in multi-threaded code. While this is likely harmless (the value stored to the function pointer will always be the same, and the update will probably be a single store), it is best to avoid the problem by making the selection at library initialisation, before any threads have started.
As the optimised nibble2base_ssse3() already uses gcc function attributes, it seems reasonable to use attribute((constructor)) on the function that selects the version to use. If the constructor does not run, it will use the non-optimised version, which is a safe default.