added thread pool to tabix operations #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it showed ~40% improvement in indexing and data retrieval on bed/sam files and ~15% on vcf files. |
whitwham
reviewed
Mar 6, 2024
tabix.1
Outdated
| @@ -78,6 +78,8 @@ and BAI index formats can handle individual chromosomes up to 512 Mbp | |||
| If your input file might contain data lines with begin or end positions | |||
| greater than that, you will need to use a CSI index. | |||
|
|
|||
| A thread pool can be used for operations except listing sequence names. | |||
There was a problem hiding this comment.
Suggestion, change "thread pool" to "threads". "thread pool" is more of an internal name.
There was a problem hiding this comment.
Also, do the same in the other places in the man file where "thread pool" is used.
There was a problem hiding this comment.
Updated and rephrased.
vasudeva8
force-pushed
the
tabix_mt
branch
2 times, most recently
from
0eaacc9 to
b913bfd
Compare
|
Updated tests as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1735.
Added option to provide number threads to use, disabled by default.
Uses the thread pool in operations except listing of sequence names (-l).