Miscellaneous trivia and minor fixes #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that this is intended to be computed as a signed off_t, but c->offset (a size_t) makes the expression unsigned. Also adjust printf specifiers and cast to PRId64's exact type.
|
Thanks, these all look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor fixes that you may wish to select from and squash:
Remove remnants of now unused
HTS_HAVE_NEON. This has already been cherry-picked into pysam, as we print it out in the logs so these remnants could have caused confusion.Remove remnants of
NUMERIC_VERSION, unused since Change MACH_O compatibility and current versions #1226. Eventually with a soversion bump you may revisit howMACH_O_CURRENT_VERSIONis set and perhaps set it fromversion.sh numeric, so that code in version.sh has been left. (We will soon not ship htslib/version.sh in pysam so will need to apply something like this to our htslib/Makefile whether htslib does or not.)Document primarily
MM/MLtags — rather than the draftMm/Ml— and fix base-mod-related typos.Avoid a “
PRId64used withsize_t” warning. This change adds a cast to the always-runif()condition as well as to the almost-never-run diagnostic printing, so deserves more review than the rest of this PR.Install annot-tsv.1 man page and alphabetise
annot-tsvrules. I thought perhaps the maintainers would rename this to something more appealing — e.g.tabanno, à latabix— before merging this new tool 😄 but in lieu of that this restores the obvious alphabetical ordering ofbgzip/htsfile/tabixet al.