Fix a couple of unused value warnings when built with NDEBUG #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings appeared due to the values only being used for assert() statements. The one in cram_stats_encoding() is just checking some counts, so the variable is just annotated with HTS_UNUSED to silence the warning. The assert() in cram_index_build() could actually be triggered with a suitably-adjusted cram file. As it therefore detects bad inputs, it is replaced with code to write a better error message and return the documented value for read errors in this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings appeared due to the values only being used for
assert()statements. The one incram_stats_encoding()is just checking some counts, so the variable is just annotated withHTS_UNUSEDto silence the warning.The
assert()incram_index_build()could actually be triggered with a suitably-adjusted cram file. As it therefore detects bad inputs, it is replaced with code to write a better error message and return the documented value for read errors in this function.The attached bad_len.zip file contains an example that can be used to test
cram_index_build()via