Report HTS_CFLAGS_AVX2 et al in make print-config
#1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information (probed for by configure) may also be of use to third parties.
|
Thanks - a good idea. Is there any benefit to extending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
print-configtarget added in 155e1aa. This target-specific compiler flag information (probed for by configure) may also be of use to third parties.In particular, pysam's current build infrastructure will need this information — cf pysam-developers/pysam#1112.
Pysam might in future switch to using HTSlib's build infrastructure to build libhts.a (rather than using Python setuptools machinery to build the object files listed in
LIBHTS_OBJSas reported byprint-config), but this would still be of use to other third parties.