Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include definition for MSVC ssize_t #1375

Closed
wants to merge 1 commit into from

Conversation

BickfordA
Copy link
Contributor

Adding the definition for ssize_t would allow for compiling with MSVC c11/c17.

@jmarshall
Copy link
Member

See the previous discussion in #1025.

@jkbonfield
Copy link
Contributor

Our main work is on Unix/MacOS, and Windows support so far has been using Unix-derived compilers, such as the MinGW tool chain. We just don't have the capacity in group to fully support all the nuances of another platform.

However, if it really is just 1 or 2 very minor things, then perhaps we can add definitions which aid compilation. However it's not something we're likely to be doing in a continuous integration service (unless you wish to contribute magic to make that work too) so it's always potentially going to break again.

Can you confirm how many other problems there are when compiling with MSVC? Ie when doing a "make -k" to let it continue beyond errors, how many types of error are there?

@BickfordA
Copy link
Contributor Author

BickfordA commented Jan 11, 2022

Thanks for looking at this! This and the static array initialization reference in: #1374 were the only changes i needed. Everything else could be handled with #defines and some options in the config.h.

I also saw this ticket which looks like maybe some forward movement in this direction: #1377

Happy to help if I can! I could also could put the block behind a flag so that it could be turned on/off if people don't want the behavior.

I currently am using CMake to drive the compilation (so some files are not being built tests, plugins etc) but i could look at using nmake and getting the out put of the compilation if that would be helpful.

@jkbonfield
Copy link
Contributor

Closing as replaced by #1377 (now merged).

@jkbonfield jkbonfield closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants