Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed redundant code that sets the secondary alignment flag for a r… #1664

Merged

Conversation

KleinSamuel
Copy link

…eadpair

Description

Short:
Removed duplicate code fragment that had no effect.

Long:
When adding a new read pair to a SAMRecord using the addPair() method in SAMRecordSetBuilder,
the parameters "record1NonPrimary" as well as "record2NonPrimary" are checked to set the
secondary alignment flag of the SAM record. This code fragment for both reads was duplicated with
no effect. The duplicate is removed in this PR.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thank you!

@lbergelson lbergelson merged commit 5404ca2 into samtools:master Jul 28, 2023
@KleinSamuel KleinSamuel deleted the remove_redundant_nonprimary_flag branch August 2, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants