Fix restoration of read base feature code. #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnbroad
force-pushed
the
cn_cram_compliance
branch
from
214a220 to
d572221
Compare
|
@yash-puligundla FYI, in case you have review comments or questions (for some reason I can't tag you as a reviewer). You might want to include these changes for any subsequent compliance tests your run. |
|
Thank you, Chris. I will do that.
…On Tue, Jan 4, 2022 at 8:58 AM Chris Norman ***@***.***> wrote:
@yash-puligundla <https://github.com/yash-puligundla> FYI, in case you
have review comments or questions (for some reason I can't tag you as a
reviewer). You might want to include these changes for any subsequent
compliance tests your run.
—
Reply to this email directly, view it on GitHub
<#1590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVHVIITEJPNM6GOKZ7ODK5DUUL4GZANCNFSM5LF6UQIA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
lbergelson
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1379. This was originally marked as fixed in the 2020 refactoring branch, but @yash-puligundla ran into it while verifying compliance with hts-specs files for #1587.