Add LiftOver constructor that takes an input stream #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig hosted in S3.
…nfig hosted in S3.
…rsavage/htsjdk into ks_lift_over_from_input_stream
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
===============================================
+ Coverage 68.115% 68.118% +0.004%
- Complexity 8375 8378 +3
===============================================
Files 573 573
Lines 33978 33982 +4
Branches 5668 5668
===============================================
+ Hits 23144 23148 +4
Misses 8644 8644
Partials 2190 2190
|
lbergelson
requested changes
Aug 22, 2019
There was a problem hiding this comment.
@kevinpetersavage Thank you for this PR. Really nice first PR! Thank you for adding tests. I made a number of comments about ways that I think this could be slightly improved. Let me know if you have any questions.
|
@lbergelson thanks for the really good feedback, definitely improved the code! |
lbergelson
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desrciption
Add LiftOver constructor that takes an input stream. This is so that it can be used in situations where the config is not on a file system. In my case it is on AWS S3.
Checklist