Suppress all exceptions during DeleteOnExitPathHook #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently we were not catching some commonly thrown exceptions like RuntimeIOException while deleting files at shutdown. This results in confusing error messages at program exit which can mask the actual cause of failures. Now we catch all exceptions and output a log message at debug level in case anyone is interested in seeing the failures.
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
===============================================
+ Coverage 68.101% 68.102% +0.002%
Complexity 8373 8373
===============================================
Files 573 573
Lines 33963 33965 +2
Branches 5668 5668
===============================================
+ Hits 23129 23131 +2
+ Misses 8645 8644 -1
- Partials 2189 2190 +1
|
cmnbroad
reviewed
Aug 15, 2019
There was a problem hiding this comment.
@lbergelson Seems like a good idea in general, but do you know if logging during shutdown works correctly ?
|
I don't know why it wouldn't. It's basically just writing to system.err so unless you're 100% out of memory it doesn't seem like it would be problematic. I googled for restrictions on shutdown hooks and the only thing that's definitely not allowed is registering a new shutdown hook. I'm definitely not an expert on it though, so I might be wrong... |
cmnbroad
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This results in confusing error messages at program exit which can mask the actual cause of failures.
Now we catch all exceptions and output a log message at debug level in case anyone is interested in seeing the failures.