fix small bug in VariantContextBuilder #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up braces while I'm at it.
yfarjoun
commented
Aug 1, 2019
| @@ -435,6 +434,7 @@ public VariantContextBuilder passFilters() { | |||
| */ | |||
| public VariantContextBuilder unfiltered() { | |||
| this.filters = null; | |||
| this.filtersCanBeModified = false; | |||
yfarjoun
commented
Aug 1, 2019
|
|
||
|
|
||
| @Test | ||
| public void testCanResetFilters() { |
There was a problem hiding this comment.
this test failed prior to adding the bugfix.
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
===============================================
+ Coverage 68.116% 68.118% +0.003%
Complexity 8369 8369
===============================================
Files 573 573
Lines 33929 33938 +9
Branches 5667 5667
===============================================
+ Hits 23111 23118 +7
- Misses 8629 8631 +2
Partials 2189 2189
|
lbergelson
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
@yfarjoun I changed the deeply nested
else {
if {}
}
blocks to flatter
else if {}
variants because I think they're more readable. Any objection?
yfarjoun
commented
Aug 2, 2019
| * @return this builder | ||
| */ | ||
| public VariantContextBuilder filters(final String ... filters) { | ||
| if(filters == null){ |
There was a problem hiding this comment.
Suggested change
| if(filters == null){ | |
| if (filters == null) { |
yfarjoun
commented
Aug 2, 2019
| builder.filters((Set<String>)null); | ||
| builder.make(); | ||
| } | ||
|
|
yfarjoun
commented
Aug 2, 2019
|
Thanks @lbergelson for taking over this. happy with your changes with a few comments. Feel free to merge after addressing them. |
lbergelson
force-pushed
the
yf_can_add_filter_after_unfiltered
branch
from
c05c1e2 to
f63282e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Things to think about before submitting: