-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few fixes for issues found by spotbugs #1278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
==============================================
+ Coverage 67.49% 67.584% +0.094%
- Complexity 8150 8189 +39
==============================================
Files 558 558
Lines 33365 33375 +10
Branches 5608 5609 +1
==============================================
+ Hits 22518 22556 +38
+ Misses 8658 8637 -21
+ Partials 2189 2182 -7
|
src/main/java/htsjdk/samtools/cram/encoding/readfeatures/Substitution.java
Outdated
Show resolved
Hide resolved
Thanks for taking a look @jmthibault79 |
src/test/java/htsjdk/samtools/cram/encoding/ReadFeaturesTest.java
Outdated
Show resolved
Hide resolved
jmthibault79
approved these changes
Feb 19, 2019
Resolves #1220 |
Thank you @tomwhite and @jmthibault79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address more of #1267
Checklist