Fix to ensure that SeekableStream#available() never returns a negative value #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e value. For files that are larger than 2GB (e.g. an uncompressed FASTA) it is possible that `length - position` overflows an int, resulting in a negative value being returned.
|
@cmnbroad @lbergelson can you review please? |
lbergelson
reviewed
Jan 9, 2019
| @@ -107,8 +107,13 @@ public int available() throws IOException { | |||
| return 0; | |||
There was a problem hiding this comment.
This method is cursed.... @droazen
|
I really wish that java would throw exceptions on overflow... |
lbergelson
approved these changes
Jan 9, 2019
|
I wonder if there are any static analysis tools that would have pointed this out as a probable error... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For files that are larger than 2GB (e.g. an uncompressed FASTA) it is possible that
length - positioninSeekableStream#available()overflows an int, resulting in a negative value being returned.This fixes the problem described here: broadinstitute/gatk#5547
Checklist