Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finals for issues raised during review of PR 1091. #1240

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Dec 10, 2018

Add a few finals, pre request during review of #1091.

@lbergelson
Copy link
Member

@cmnbroad Thank you.

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #1240 into master will increase coverage by 0.015%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1240       +/-   ##
===============================================
+ Coverage     69.378%   69.393%   +0.015%     
- Complexity      8107      8108        +1     
===============================================
  Files            544       544               
  Lines          32434     32434               
  Branches        5495      5495               
===============================================
+ Hits           22502     22507        +5     
+ Misses          7732      7728        -4     
+ Partials        2200      2199        -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/samtools/CRAMIterator.java 79.72% <ø> (ø) 33 <0> (ø) ⬇️
...dk/samtools/seekablestream/SeekableHTTPStream.java 57.353% <0%> (-1.471%) 13% <0%> (-1%)
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️
...sjdk/samtools/util/Md5CalculatingOutputStream.java 74.359% <0%> (+7.692%) 8% <0%> (+1%) ⬆️

@lbergelson lbergelson merged commit fb2f42c into samtools:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants