-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding getPathToDataFile default method to FeatureCodec #1223
Conversation
* adding a new method FeatureCodec.getPathToDataFile() - This method allows a special class of codec where the files that they accept are a configuration file and the actual data is stored elsewhere. - The default implementation means that existing codecs do not need to be modified in any way * modifing AbstractFeatureReader and it's subclasses to use getPathToDataFile * downstream tools that implement their own FeatureReader subclasses may want to update them to be aware of getPathToDataFile if they want to understand these codecs
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
===============================================
- Coverage 69.016% 68.938% -0.078%
- Complexity 8066 8197 +131
===============================================
Files 539 539
Lines 32552 32973 +421
Branches 5488 5591 +103
===============================================
+ Hits 22466 22731 +265
- Misses 7890 8012 +122
- Partials 2196 2230 +34
|
@jrobinso As a heads up, this touches |
@lbergelson thanks for the heads up, I agree I don't see any impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete, back to @lbergelson. Minor comments, merge after addressing them.
accept are a configuration file and the actual data is stored elsewhere.
want to update them to be aware of getPathToDataFile if they want to
understand these codecs
Checklist