-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing htsjdk to produce sam version 1.6 #1211
Conversation
* Htsjdk has techinically been producing Sam version 1.6 since support for long cigars was added. * Updating that list of acceptable versions to include 1.6 and setting the header version of new bams to 1.6
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
===============================================
+ Coverage 68.702% 68.796% +0.095%
- Complexity 8061 8094 +33
===============================================
Files 542 542
Lines 32711 32887 +176
Branches 5533 5577 +44
===============================================
+ Hits 22473 22625 +152
- Misses 8038 8054 +16
- Partials 2200 2208 +8
|
Co-Authored-By: lbergelson <louisb@broadinstitute.org>
Co-Authored-By: lbergelson <louisb@broadinstitute.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look fine. The only question I have is whether there are any special cases we need to consider when merging old headers with 1.6 headers ? Otherwise LGTM.
👍 to taking this and addressing #1202 separately. |
Checklist