Fix compression of data blocks close to 2GB in size. #55
Conversation
| @@ -93,7 +93,7 @@ static unsigned char *load(FILE *infp, uint32_t *lenp) { | |||
| */ | |||
| int main(int argc, char **argv) { | |||
| int opt, order = 0; | |||
| unsigned char in_buf[BLK_SIZE2+257*257*3]; | |||
| unsigned char *in_buf = malloc(BLK_SIZE2+257*257*3); | |||
There was a problem hiding this comment.
Address sanitizer complains that this gets leaked.
The similar changes to malloc'd blocks in the other tests seem to get a pass as the buffers being replaced are currently global.
There was a problem hiding this comment.
It's true, but I didn't think it'd matter given it's essentially the same as a huge static array (it's freed on program exit). I forgot about automated tests highlighting it though. I'll fix as it's useful to be able to use the test tools complaint-free to look for problems elsewhere.
I did also think about checking for NULL, but frankly if it can't fit then it wouldn't have fitted before and both would just die. Not a problem given this isn't a production tool, unless a compiler is going to start asserting error checking.
(We still have a limit of >2GB though) Reported by Divon Lan
|
The fixes look OK. I think it would be a good idea to add explicit checks on the 2 Gbyte limit though. At the moment it's not obvious if there is a limit, and it looks like there will be problems if you try to go over that. |
Also limit input buffer sizes to 2GB.
|
I added checks for the 2GB limit so it just returns a hard NULL early on. |
(We still have a limit of >2GB though)
Reported by Divon Lan