Update MAINTAINERS.md #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyenyxe
approved these changes
Aug 19, 2019
jmarshall
reviewed
Aug 19, 2019
MAINTAINERS.md
Outdated
| * Louis Bergelson (@lbergelson) | ||
| * Petr Danecek (@pd3) | ||
|
|
||
| Past VCF/BCF maintainers include Ryan Poplin and David Roazen. | ||
| Past VCF/BCF maintainers include Ryan Poplin, David Roazen and Cristina Yenyxe Gonzalez Garcia. |
There was a problem hiding this comment.
Suggested change
| Past VCF/BCF maintainers include Ryan Poplin, David Roazen and Cristina Yenyxe Gonzalez Garcia. | |
| Past VCF/BCF maintainers include Ryan Poplin, David Roazen, and Cristina Yenyxe Gonzalez Garcia. |
For the record, does @cyenyxe sort herself (by surname) at G or Y?
There was a problem hiding this comment.
I was not aware of any name ordering in this page, should I change this?
Sorting by surname 'Gonzalez' should be used, as it's a spanish name.
There was a problem hiding this comment.
Whether the current maintainers are sorted, and if so how, is an open question (cf #415). (If it were me, I would add myself at the bottom, but that's just MHO.)
The lists of past maintainers are alphabetical (and use Oxford commas).
jmarshall
approved these changes
Aug 19, 2019
lbergelson
approved these changes
Aug 19, 2019
|
Where do I sign... ? Go for it. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.