-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-world usage of 0x200 failedVendorQualityChecks flag #85
Comments
I support this. |
With hiseqX this is true since there are so many failed reads, but with the On Fri, May 8, 2015 at 9:39 AM, Heng Li notifications@github.com wrote:
|
John just changed this flag to something more general. It would not cause any compatible issues as far as I see. Broad can still use this flag to mark PF'ed reads. |
I support this as well. |
Hi,
I might be missing something but I couldn't find 0x800 bit definition from
the BAM spec in the v3 spec document for CRAM.
The flag is included in the code
(htsjdk/samtools/cram/structure/CramCompressionRecord.java:41), but not in
the document.
I presume that this is a typo, but I just wanted to make sure before
changing the document.
Yossi.
|
sorry, I should have checked the issues. Y. On Tue, Oct 20, 2015 at 10:37 AM, John Marshall notifications@github.com
|
Per samtools/hts-specs#85, this flag now represents "this alignment is filtered out" in general. Eventually parse_flags() will no longer parse 'q' as QUALITY_FAILED, perhaps when we come up with another flag wanting the letter 'q'.
The SAM specification describes the 0x200 flag bit as not passing quality controls (and the pre-LaTeX version of the spec described it as the read fails platform/vendor quality checks).
It also describes it as the filtered bit in §2 (Recommended Practices) when introducing annotation dummy reads:
In the real world today, do we actually see bad-quality reads in BAM files with their not passing quality controls flags set?
@lh3 recently commented elsewhere that "almost no one uses failedVendorQualityChecks nowadays". Probably the usual practice is for such quality-failed reads to be just omitted from BAM files rather than kept and marked with this flag, and probably this has been the case for quite some time.
Would it be worth repurposing this flag as a general this-read-is-filtered-out flag? This would be as simple as changing the description in the flag bit table, e.g.:
The text was updated successfully, but these errors were encountered: