Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese mis-mapping #88

Closed
mogando668 opened this issue May 20, 2024 · 1 comment · Fixed by #91
Closed

Chinese mis-mapping #88

mogando668 opened this issue May 20, 2024 · 1 comment · Fixed by #91

Comments

@mogando668
Copy link

mogando668 commented May 20, 2024

i'm Chinese/English bi-lingual mothertongue (the lovely peculiarity of being from HKG), and I think your Chinese mappings might be slightly off :


  months: ['一月份', '二月份', '三月份', '四月份', '五月份', '六月份', '七月份', '八月份', '九月份', '十月份', '十一月份', '十二月份'],
            shortMonths: ['一月', '二月', '三月', '四月', '五月', '六月', '七月', '八月', '九月', '十月', '十一月', '十二月'],
           

Both months and shortMonths should be using the existing values from shortMonths. Having the suffixes make them adjectives, describing "things happening in July", etc,

but that's very awkward when used in a calendar context.

@samsonjs
Copy link
Owner

Thanks for your report! Please open a pull-request with your proposed changes and I'll make a new release soon.

samsonjs added a commit that referenced this issue Jun 11, 2024
Change as described by @mogando668, closes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants