Fix setting CMAKE_GENERATOR "Ninja" in config.cmake (apache#17742)

This is not supported anymore, as we moved from `cmake -C ../config.cmake ..` syntax to `cmake ..`. Without `-C`, the config file is read too late and we can't modify the generator anymore. Ask users to run `cmake -GNinja ..` instead.
samskalicky · Mar 4, 2020 · 64d8e0f · 64d8e0f
1 parent 6368977
commit 64d8e0f
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 8 deletions.
diff --git a/config/darwin.cmake b/config/darwin.cmake
@@ -55,8 +55,6 @@ set(USE_TVM_OP OFF CACHE BOOL "Enable use of TVM operator build system.")
 #---------------------
 # Compilers
 #--------------------
-set(CMAKE_GENERATOR "Ninja" CACHE STRING "Build Tool Generator used by CMake")
-
 # Compilers are usually autodetected. Uncomment and modify the next 3 lines to
 # choose manually:
 

diff --git a/config/linux.cmake b/config/linux.cmake
@@ -73,8 +73,6 @@ set(USE_TVM_OP OFF CACHE BOOL "Enable use of TVM operator build system.")
 #---------------------
 # Compilers
 #--------------------
-set(CMAKE_GENERATOR "Ninja" CACHE STRING "Build Tool Generator used by CMake")
-
 # Compilers are usually autodetected. Uncomment and modify the next 3 lines to
 # choose manually:
 

diff --git a/config/linux_gpu.cmake b/config/linux_gpu.cmake
@@ -73,8 +73,6 @@ set(USE_TVM_OP OFF CACHE BOOL "Enable use of TVM operator build system.")
 #---------------------
 # Compilers
 #--------------------
-set(CMAKE_GENERATOR "Ninja" CACHE STRING "Build Tool Generator used by CMake")
-
 # Compilers are usually autodetected. Uncomment and modify the next 3 lines to
 # choose manually:
 

diff --git a/docs/static_site/src/pages/get_started/osx_setup.md b/docs/static_site/src/pages/get_started/osx_setup.md
@@ -110,7 +110,7 @@ the guide in [Math Library Selection](build_from_source#math-library-selection).
 ```bash
 rm -rf build
 mkdir -p build && cd build
-cmake ..
+cmake -GNinja ..
 cmake --build .
 ```
 

diff --git a/docs/static_site/src/pages/get_started/ubuntu_setup.md b/docs/static_site/src/pages/get_started/ubuntu_setup.md
@@ -130,7 +130,7 @@ the guide in [Math Library Selection](build_from_source#math-library-selection).
 ```bash
 rm -rf build
 mkdir -p build && cd build
-cmake ..
+cmake -GNinja ..
 cmake --build .
 ```