Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lock updates #1051

Merged
merged 3 commits into from
May 18, 2024
Merged

Test lock updates #1051

merged 3 commits into from
May 18, 2024

Conversation

samschott
Copy link
Owner

@samschott samschott commented May 16, 2024

  • Fix an issue with the test lock being deleted in cleanup before test case.
  • Simplify pytest fixtures.
  • Aquire lock on per-session instead of per-test-case.
  • Aquire lock for a max timeout of 10 min and renew for another 10 min for each test case.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (7666b12) to head (1e58da3).
Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1051       +/-   ##
===========================================
+ Coverage   55.86%   79.03%   +23.17%     
===========================================
  Files          42       42               
  Lines        7551     7551               
===========================================
+ Hits         4218     5968     +1750     
+ Misses       3333     1583     -1750     
Flag Coverage Δ
pytest 79.03% <ø> (+23.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samschott samschott force-pushed the test-lock-updates branch from b89ddbd to 98eca84 Compare May 18, 2024 12:23
@samschott samschott force-pushed the test-lock-updates branch from 98eca84 to 1e58da3 Compare May 18, 2024 12:26
@samschott samschott merged commit 9125336 into main May 18, 2024
12 checks passed
@samschott samschott deleted the test-lock-updates branch May 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant