Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat logs #19

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Feat logs #19

merged 6 commits into from
Jun 20, 2024

Conversation

Threated
Copy link
Member

@Threated Threated commented Mar 20, 2024

Is this fine for logging?
It creates newline delimited json where each entry has the following schema:

{
  "id": "the uuid of the task",
  "query": "b64 encoded query",
  "user_email": "someone@test.com",
  "results": ["mainz"], // Subset of sites which responded before timeout with a Successful result
  "sites": ["frankfurt", "mainz"], // Only proxy name of the site
  "ts": 17109385271000 // Unix timestamp of when the task was created
}

@Threated Threated requested a review from torbrenner March 20, 2024 13:06
@torbrenner
Copy link
Contributor

i think that is a good base for logging. One information is missing, the user which executed the search, but this will involve lens also sending more information to spot. I have a prototypical implementation for sending that information in lens project-manager-connection branch maybe we could look at it together if that can work for logging.

@Threated
Copy link
Member Author

If that information is included in the first post request it should be trivial to add.

@torbrenner
Copy link
Contributor

Yes, thats right. I think the main issue is getting that data into the first post requests. Currently the ui and backend don't have anything todo with the authentication, as the oauth2-proxy in front of them is handling authentication, but i think it should be possible to make it requestable or add it to the request.

@Threated Threated mentioned this pull request Jun 19, 2024
@Threated Threated merged commit 2bf93fc into main Jun 20, 2024
13 checks passed
@Threated Threated deleted the feat/logs branch June 20, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants