Fix Unexpected Behaviour of Count Obfuscation #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First we now return zero when the actual value is zero in order to keep unnecessary workloads away from the sites. Second, we changed the epsilon from 0.12 to 0.28 in order to lower the standard derivation from about 11 to about 5 in order to get back to about the same variation as the old algorithm. Third, we changed the sensitivity of the sample count to 10, because most patients will have about 10 samples.
|
SonarCloud Quality Gate failed. |
TKussel
approved these changes
Nov 23, 2022
src/test/java/de/samply/share/client/util/connector/LaplaceMechanismTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First we now return zero when the actual value is zero in order to keep unnecessary workloads away from the sites.
Second, we changed the epsilon from 0.12 to 0.28 in order to lower the standard derivation from about 11 to about 5 in order to get back to about the same variation as the old algorithm.
Third, we changed the sensitivity of the sample count to 10, because most patients will have about 10 samples.