Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation for standalone Bridgehead #144

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

DavidCroftDKFZ
Copy link
Member

Requested by Zdenka

Copy link
Contributor

@patrickskowronekdkfz patrickskowronekdkfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should advise what is the minimum of version of git, curl and docker.

Copy link
Member

@TKussel TKussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my suggestion for change is exactly that: a suggestion.

README.md Outdated
Comment on lines 37 to 39
We recommend a dedicated VM for the Bridgehead, with nothing else running on it.

It may to be possible to run other apps on the same server, if they don't share common ports with the Bridgehead, and if they do not take up resources that the Bridgehead needs, like RAM. The Bridgehead may also have problems if other applications need older versions of git, Docker or curl.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We recommend a dedicated VM for the Bridgehead, with nothing else running on it.
It may to be possible to run other apps on the same server, if they don't share common ports with the Bridgehead, and if they do not take up resources that the Bridgehead needs, like RAM. The Bridgehead may also have problems if other applications need older versions of git, Docker or curl.
To guarantee a smooth operation of the Bridgehead, we recommend a dedicated VM for the Bridgehead, with no other applications running on it.
It may to be possible to run other apps on the same server, if they don't share common ports with the Bridgehead, and if they do not take up resources that the Bridgehead needs, like RAM. The Bridgehead may also run into issues if other applications need incompatible versions of git, Docker, curl, or other dependencies.

@TKussel
Copy link
Member

TKussel commented Feb 20, 2024

We should advise what is the minimum of version of git, curl and docker.

We already state the required versions in https://github.com/samply/bridgehead?tab=readme-ov-file#software

@lablans lablans changed the base branch from main to develop August 1, 2024 07:52
@lablans lablans merged commit aca22fb into develop Aug 1, 2024
@lablans lablans deleted the documentation/sharing_vm branch August 1, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants