Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetStandard 2.0 support #35

Closed
cd21h opened this issue Mar 30, 2018 · 12 comments
Closed

NetStandard 2.0 support #35

cd21h opened this issue Mar 30, 2018 · 12 comments

Comments

@cd21h
Copy link

cd21h commented Mar 30, 2018

Please add NetStandard 2.0 binaries to NuGet

cd21h added a commit to cd21h/RedLock.net that referenced this issue Mar 30, 2018
@validide
Copy link

What are the benefits of targeting a higher version?
As far as I know lower is better for NuGet pacakges and also recommend by Microsoft.

@samcook
Copy link
Owner

samcook commented Apr 11, 2018

That was my thought too. The current library targeting NetStandard 1.5 is usable with both .NET Core 1.0 and 2.0 (and .NET Framework 4.6.1+).

Is there a benefit to having a version targeting NetStandard 2.0 (when it isn't using any of the additional APIs made available in that version)?

@andymac4182
Copy link

Netstandard2.0 resolves a decent amount of referencing netstandard issues from my understanding.

@cd21h
Copy link
Author

cd21h commented Apr 13, 2018

Build process: dotnet restore won't pull older versions during the build

@samcook
Copy link
Owner

samcook commented Apr 13, 2018

@Shatl can you clarify what you mean? I'm not sure what the problem is.

@cd21h
Copy link
Author

cd21h commented Apr 17, 2018

@samcook When building on NetStandard 2 docker image (aspnetcore-build:2) dotnet restore has to pull NetStandard dependencies which increases build time

@ig-sinicyn
Copy link

Up this. We have a failed build after upgrade to 4.7.2 due to assembly conflicts.

@samcook
Copy link
Owner

samcook commented Jun 9, 2018

I've pushed out a prerelease package (version 2.1.0-pre2) which now includes a NetStandard 2.0 target, and tweaks the nuget dependencies a little.

Any feedback on whether this solves the referencing issues people have mentioned is appreciated.

@ig-sinicyn
Copy link

ig-sinicyn commented Jun 10, 2018 via email

@cd21h
Copy link
Author

cd21h commented Jun 11, 2018

Works fine. Thanks!

@cd21h
Copy link
Author

cd21h commented Jul 12, 2018

@samcook Could you publish release package ?

@samcook
Copy link
Owner

samcook commented Sep 5, 2018

Done (finally!)

@samcook samcook closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants