Support for tuple type #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchon
reviewed
Apr 24, 2023
src/Primitive.ts
Outdated
| ? _Primitive<T>[] | ||
| ? IsTuple<Instance> extends true | ||
| ? Instance extends [infer F, ...infer Rest] | ||
| ? [F, ..._PrimitiveObject<Rest>] |
There was a problem hiding this comment.
It would better to make a new type to reduce vulnerable iteration depths
There was a problem hiding this comment.
Thx for your review. But we were going back a long way, leaving an easier way. :)
- There was a much simpler way.
samchon
added a commit
to samchon/nestia
that referenced
this pull request
Apr 26, 2023
@kakasoo has advanced `Primitive` type in `typia`, and `nestia` also accepts it. samchon/typia#601
samchon
added a commit
to samchon/nestia
that referenced
this pull request
Apr 26, 2023
@kakasoo has advanced `Primitive` type in `typia`, and `nestia` also accepts it. samchon/typia#601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the hint you gave me, I could solve it easily.
I ran the test automation module with the bash script in the content of the CONTRIBUTING document and it was successful.